Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxboot: Pass $CPUS to edk2/OvmfPkg/build.sh unerroneously #940

Merged
merged 1 commit into from
Dec 26, 2020

Conversation

synackd
Copy link
Contributor

@synackd synackd commented Dec 26, 2020

On a clean checkout of HEADS when attempting to build the qemu-linuxboot board, configuration of Linuxboot fails:

Pre-building edk2 OVMF
Initializing workspace
/home/docker/workspace/heads/build/linuxboot-git/edk2/BaseTools
Loading previous configuration from /home/docker/workspace/heads/build/linuxboot-git/edk2/Conf/BuildEnv.sh
WORKSPACE: /home/docker/workspace/heads/build/linuxboot-git/edk2
EDK_TOOLS_PATH: /home/docker/workspace/heads/build/linuxboot-git/edk2/BaseTools
CONF_PATH: /home/docker/workspace/heads/build/linuxboot-git/edk2/Conf
using prebuilt tools
Running edk2 build for OvmfPkgX64
Usage: build.exe [options] [all|fds|genc|genmake|clean|cleanall|cleanlib|modules|libraries|run]

build.exe: error: option -n: invalid integer value: 'PUS'

Changing $$CPUS to $(CPUS) in modules/linuxboot fixes this.

@synackd
Copy link
Contributor Author

synackd commented Dec 26, 2020

This PR addresses this discussion.

@tlaurion tlaurion merged commit 6ed1f3a into linuxboot:master Dec 26, 2020
@synackd synackd deleted the qemu-linuxboot-cpus branch December 26, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants