(WiP) xx20 boards: add xx20-hotp-maximized & remove HOTP and NITROCLI support from xxx0-maximized boards #928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Thrilleratplay should be that originally I guess, where you can't test hotp right?
Also unsure if NKSTORAGECLI should be here, since they needed to be removed under tlaurion@00c2fff for https://app.circleci.com/pipelines/github/tlaurion/heads/648/workflows/337f0829-e3e9-47aa-85b1-1e10a9199e54/jobs/696 to build (cryptsetup2 support for future #789 support since LUKS2 at default install)
Doesn't build as of right now, since boards configs declare cryptsetup2 dependency.EDIT: removed dependency to cryptsetup2. Should not be linked issues.