Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WiP) xx20 boards: add xx20-hotp-maximized & remove HOTP and NITROCLI support from xxx0-maximized boards #928

Merged
merged 2 commits into from
Dec 13, 2020

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Dec 12, 2020

  • xx20-maximized boards were supporting HOTP by error. This adds the xx20-hotp-maximized boards and removes HOTP support from xx20-maximized boards for coherence with the xx30-maximized boards.
  • Add those boards to CircleCI.

@Thrilleratplay should be that originally I guess, where you can't test hotp right?

Also unsure if NKSTORAGECLI should be here, since they needed to be removed under tlaurion@00c2fff for https://app.circleci.com/pipelines/github/tlaurion/heads/648/workflows/337f0829-e3e9-47aa-85b1-1e10a9199e54/jobs/696 to build (cryptsetup2 support for future #789 support since LUKS2 at default install)

Doesn't build as of right now, since boards configs declare cryptsetup2 dependency. EDIT: removed dependency to cryptsetup2. Should not be linked issues.

@tlaurion tlaurion changed the title xx20 boards: add xx20-hotp-maximized & remove HOTP support from xx20-maximized boards (WiP) xx20 boards: add xx20-hotp-maximized & remove HOTP support from xx20-maximized boards Dec 12, 2020
… xx20-boards. Modify CircleCI conf accordingly.
@Thrilleratplay
Copy link
Contributor

@tlaurion I do not have a Nitrokey/LibremKey so I was not able to test this. I only included them to match xx30 boards.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Dec 12, 2020

@Thrilleratplay which is why I seperated this into xx30 as well. Now xx20-maximized builds do not contain HOTP (which you can test) and xx20-htop which you can't. Merge?

As a result, https://703-103208611-gh.circle-artifacts.com/0/build/x220-hotp-maximized/heads-x220-hotp-maximized-v0.2.0-973-g16488fb.rom should be testable by you and all others not having a HOTP compliant USB Security dongle.

@tlaurion
Copy link
Collaborator Author

As a side note, I would go forward and remote NKSTORECLI inside of those board configs also, reducing future maintenance of those boards (nobody wants NKSTORECLI by default). I will go forward and we wil lbe able to use those two builds to compare size difference.

That would close #926 (comment) with one stone.

@Thrilleratplay
Copy link
Contributor

@tlaurion I understand that but CONFIG_HOTPKEY=y was taken from x230-maximized. If it is being removed from the xx20-maximized boards, they should also removed from the xx30-maximized boards. I assume would be the same for CONFIG_NKSTORECLI=y in xx30-maximized and xx20-maximixed boards.

If doing so allows for enough room for cryptsetup2 to be installed in the xx20-maximized boards and does not take away any functionality, then I would suggest doing so for the xx30-maximized boards too. This will keep them functionally the same for now.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Dec 13, 2020

Agreed. pushing. Will create a x230-PrivacyBeast later on for my own needs adding this in when needed I guess instead of using the xx30-htop-maximized.

@tlaurion tlaurion changed the title (WiP) xx20 boards: add xx20-hotp-maximized & remove HOTP support from xx20-maximized boards (WiP) xx20 boards: add xx20-hotp-maximized & remove HOTP and NITROCLI support from xxx0-maximized boards Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants