Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xx30 boards: suspend/resume fix #838

Merged

Conversation

tlaurion
Copy link
Collaborator

As explained here (@Thrilleratplay that NEEDS to be documented in development section/board porting...), CBFS region needs to be consistent to what is really available in IFD.

The suspend resume issues reported #770 #608, and blank screen upon internal flashing reported #737 were linked to CBFS mismatches. Thanks to @alex-nitrokey to have tested #770 (comment), since changing CBFS region a while ago caused this regression.

Drops:

  • dropbear
  • e1000e

Adds:

  • hotp-verification

@Thrilleratplay
Copy link
Contributor

@tlaurion I'll add it.

@tlaurion tlaurion changed the title X230-hotp-verification suspend/resume fix xx30 boards: suspend/resume fix Oct 16, 2020
@tlaurion
Copy link
Collaborator Author

tlaurion commented Oct 16, 2020

Decided to generalize the concept, since this problem SHOULD affect all boards that have the same IFD map not matching BIOS region (where CONFIG_CBFS_SIZE=0x710000 SHOULD really be CONFIG_CBFS_SIZE=0x700000)

from #692 listed board tester:
t430 (xx30): @flawedworld is listed as a tester. Do you suffer from suspend/resume issues also?
the t430 coreboot config currently specifies CONFIG_CBFS_SIZE=0x710000, which should show exactly the same problem.

@tlaurion
Copy link
Collaborator Author

@Thrilleratplay what platforms do you have? I see you are not listed under #692 ?

@Thrilleratplay
Copy link
Contributor

@tlaurion I posted a list to #692

@tlaurion
Copy link
Collaborator Author

@Thrilleratplay So you have a T430. Is it suffering from suspend/resume issue with coreboot config specifying CONFIG_CBFS_SIZE=0x710000 instead of CONFIG_CBFS_SIZE=0x700000?

@tlaurion
Copy link
Collaborator Author

Ci failing for coreboot 4.12 not downloading.... Retrying until it passes.

@Thrilleratplay
Copy link
Contributor

@tlaurion It is a device I use mostly for checking standard coreboot configs when updating coreboot-builder-scripts and uses CONFIG_CBFS_SIZE=0x400000. I will be a while before I can test this.

@tlaurion
Copy link
Collaborator Author

@Thrilleratplay : I will then consequently clone the x230 coreboot config and define the board with same coreboot base. It would not make any sense that it works. Just a false negative from lack of response from board users, based on this post. That region cannot be larger then CONFIG_CBFS_SIZE=0x700000 if IFD is not resized from liberated ME neutered and freed space, which is another debate and should be another board config, unless #703 is generalized, for which we don't have consensus yet.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Oct 17, 2020

TODO: cherry pick Nitrokey@ad75d8e, extend and comment linking to #667 (comment)

Will fix #770

@tlaurion
Copy link
Collaborator Author

Oups..... needs rebase on master

g++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
make[1]: *** [Makefile:1110: insn-emit.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm gcc.pod
make[1]: Leaving directory '/root/project/build/coreboot-4.12/util/crossgcc/build-i386-elf-GCC/gcc'
make: *** [Makefile:4244: all-gcc] Error 2

@tlaurion tlaurion force-pushed the x230-hotp-verification_suspend-resume-test branch from 99ea5a2 to caff212 Compare October 17, 2020 16:42
@tlaurion
Copy link
Collaborator Author

I confirm the fix for x230 and x230-hotp-verification.
I think it is a safe bet to generalize that it should also fix for t430.

@flawedworld, please test master when you have a second (artifacts from CIs are downloadable through the little green checkmark beside each commit)

@tlaurion tlaurion merged commit 30852aa into linuxboot:master Oct 19, 2020
@tlaurion tlaurion mentioned this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants