Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board: x230-hotp-verification (includes libremkey-hotp-verification) #722

Merged
merged 1 commit into from
May 22, 2020

Conversation

tlaurion
Copy link
Collaborator

Add x230-hotp-verification board with libremkey-hotp-verification in (supports remote attestation for Nitrokey Pro 2, Nitrokey Storage 2 and Librem Key)

  • Includes CircleCI config (that will need to be reverted prior of merge) that permitted to create the artifacts that can be tested here so that board can be tested.

Maybe the way to go is to add all boards that can be built without external dependencies in #571 ? Each board takes 15 minutes when CircleCI cache was built from initial build, which can be reused to build other boards configs, as tested previously.

@tlaurion
Copy link
Collaborator Author

tlaurion commented May 21, 2020

Forced pushed so that buildsystem now builds for qemu-coreboot, x230-flash, x230, and x230-hotp-verification (15 each board)

…TP supported remote attestation for Nitrokey Pro 2, Nitrokey Storage 2 and Librem Key
szszszsz added a commit to szszszsz/heads that referenced this pull request May 22, 2020
Move from CMake build system to GNU Make for hotp-verification
Change version to one supporting Makefile build

Fixes linuxboot#724
Connected:
- Nitrokey/nitrokey-hotp-verification#13
- linuxboot#722
@tlaurion tlaurion merged commit 577fd80 into linuxboot:master May 22, 2020
@MrChromebox
Copy link
Contributor

why did this need a separate coreboot config? it's the same as the regular x230 config, just cleaned up and with a larger CBFS.

@tlaurion
Copy link
Collaborator Author

tlaurion commented May 22, 2020

why did this need a separate coreboot config? it's the same as the regular x230 config, just cleaned up and with a larger CBFS.

@MrChromebox : each board needs to be coupled with a coreboot specific configuration, since modules are built in the board configuration directory (build/$BOARD), and coreboot config needs to point in that same $BOARD directory to find its initrd and other dependencies.

linux configurations can be shared across a board configurations, while coreboot configurations, right now, needs to be duplicated.

This board configuration takes into account your comments that were raised into #703.
The x230 mother board configuration is still as it was originally.

@MrChromebox
Copy link
Contributor

ah ok, thanks for clarifying -- didn't realize coreboot configs couldn't be shared currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants