Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu-coreboot-fbwhiptail board addition #708

Merged
merged 2 commits into from
May 15, 2020

Conversation

tlaurion
Copy link
Collaborator

by doing:
make BOARD=qemu-coreboot-fbwhiptail && make BOARD=qemu-coreboot-fbwhiptail run

One can test gui-init

Based on #707

Copy link
Contributor

@MrChromebox MrChromebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is adding a new board specifically for the GUI / fbwhiptail case, can go ahead and drop all the commented config items for text mode, as well the comments regarding choosing between the two

@tlaurion
Copy link
Collaborator Author

tlaurion commented May 5, 2020

@MrChromebox done

@MrChromebox
Copy link
Contributor

@tlaurion tested ok here and mostly LGTM. Though the utility is somewhat limited without any disk attached

Also, commit message for ef499f6 has the board name order incorrect though (coreboot-qemu-fbwhiptail vs qemu-coreboot-fbwhiptail).

@tlaurion tlaurion force-pushed the qemu-coreboot-fbwhiptail_board branch from aafdf66 to 2c5c64a Compare May 5, 2020 18:34
@tlaurion
Copy link
Collaborator Author

tlaurion commented May 5, 2020

@tlaurion tested ok here and mostly LGTM. Though the utility is somewhat limited without any disk attached

@MrChromebox : Agreed. those comments should be made to #516 and/or #701 which would need to be filled in for another PR to be made consequently (swtpm support, disk support, host usb support passthrough...). This is just basic board config which would benefit from love given in the two other issues pointed above.

Also, commit message for ef499f6 has the board name order incorrect though (coreboot-qemu-fbwhiptail vs qemu-coreboot-fbwhiptail).

Fixed. Thanks.

@MrChromebox
Copy link
Contributor

Fixed. Thanks.

I'm still seeing the first commit as:

Working config to do make BOARD=coreboot-qemu-fbwhiptail and then mak…

the most recent force push only changed the 2nd commit

@tlaurion tlaurion force-pushed the qemu-coreboot-fbwhiptail_board branch from 2c5c64a to 29e2800 Compare May 11, 2020 17:58
@tlaurion
Copy link
Collaborator Author

@MrChromebox fixed.

@tlaurion tlaurion merged commit 950acf9 into linuxboot:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants