Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC : D16 15h coreboot fork #1910

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tlaurion
Copy link
Collaborator

Deprecates #1805 since d16 had kernel version bump as all other boards.

This PR only takes pointed commit per modules/coreboot and point UNMAINTAINED_kgpe-d16_server-whiptail board to it, which should contain all 4.11 needed patches for Heads to support TPM1.2 as well.

Discussions about this should happen under Heads channel or here.

…it from https://git.15h.org/mrothfuss/coreboot-15h/src/branch/4.11-tpm-measured-boot dating 20250126

Once fork switched, after repo is cloned, CTRL-C and:
- ./docker_repro.sh make BOARD=UNMAINTAINED_kgpe-d16_server-whiptail coreboot.modify_and_save_oldconfig_in_place
- Enable measured boot, save changes.

Changes were saved under config/coreboot-kgpe-d16_server-whiptail.config, see diff (a lot compared to 4.11 in master)

Signed-off-by: Thierry Laurion <[email protected]>
# anything.
# Pointing to https://git.15h.org/mrothfuss/coreboot-15h/src/branch/4.11-tpm-measured-boot latest commit as of 20250129
coreboot-15h_repo := https://git.15h.org/mrothfuss/coreboot-15h.git
coreboot-15h_commit_hash := 2b7c566b463737f807a69738163344b41c686ef6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arhabd if this commit is not the latest, someone needs to take the lead and follow fam15h fork updates and redo this PR until success.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arhabd if this commit is not the latest, someone needs to take the lead and follow fam15h fork updates and redo this PR until success.

understood i will update the pr as times goes on until its been fully tested

@tlaurion
Copy link
Collaborator Author

tlaurion commented Feb 13, 2025

On need for CONFIG_BOOT_XEN_ADD CONFIG_BOOT_XEN_REMOVE grub.conf overrides:

Might be needed for #1910 considering latest Xen speculation mitigations slow down the d16 to turtle speed, where sys-net and sys-usb would need to be switched to pv instead of hvm mode see https://15h.org/index.php/QubesOS

Originally posted by @tlaurion in #890

This would be:
CONFIG_BOOT_XEN_ADD="spec-ctrl=ibpb-entry=no-pv" added under kgpe-d16 board configs, with notes there to switch sys-usb and sys-net from hvm to pv mode, pushing user to install qubes with sys-usb and sys-net being disposable vms.

Note that #890 is an issue, not a PR. Meaning a PR implementing this would be needed so that Heads can modify Xen command line arguments on kexec calls, just like it currently do for linux kernel command line arguments, specified under board configs to apply board specifics overrides to what is under grub.conf.

@tlaurion tlaurion mentioned this pull request Feb 13, 2025
12 tasks
@tlaurion
Copy link
Collaborator Author

@Tonux599 said

Sorry but I have no motivation to continue this because of QubesOS/qubes-issues#9150

Originally posted by @Tonux599 in #1634 (comment)

@tlaurion tlaurion added the port new board addition from existing coreboot port label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port new board addition from existing coreboot port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants