Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change system time feature #1730

Closed
wants to merge 3 commits into from

Conversation

alexgithublab
Copy link
Contributor

This allows to change time easily directly from the GUI.

@tlaurion
Copy link
Collaborator

tlaurion commented Jul 24, 2024

Please chmod +x and amend commit @alexgithublab : not functionally testable. (not executable).

@tlaurion
Copy link
Collaborator

@alexgithublab : Also missing notes stating this needs to be UTC/GMT timezone (system clock ) and maybe an online pure HTML5 reference for users to define this without setting local timezone (from their phone...)

See #910 (comment)

@@ -438,6 +438,7 @@ show_options_menu()
'C' ' Reencrypt LUKS container -->' \
'P' ' Change LUKS Disk Recovery Key passphrase ->' \
'R' ' Check/Update file hashes on root disk -->' \
'h' ' Change system time' \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgithublab

  • Why under gui-init option menu?
    • if under Options menu? Why so low in this menu?
  • Why not proposed under TOTP mismatch prompt as replacement for current workflow?


clear

echo -e -n "Please enter the date and time you wish to set\n"
Copy link
Collaborator

@tlaurion tlaurion Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GMT/UTC and reference to pure HTML5 url for user to look for GMT timezone clock with seconds like https://time.is/GMT or better

@alexgithublab
Copy link
Contributor Author

@tlaurion Thank you for advice, this should be better now.

@tlaurion
Copy link
Collaborator

I'm fine with this @JonathonHall-Purism ?

@tlaurion
Copy link
Collaborator

Will test #1719 (comment) against his PR which needs to be rebased on master

@tlaurion
Copy link
Collaborator

Will test #1719 (comment) against his PR which needs to be rebased on master

Cannot apply because branch is master. Creating superseeding PR with co-authoring.
@alexgithublab please read and comment https://github.com/linuxboot/heads/blob/master/CONTRIBUTING.md

@tlaurion
Copy link
Collaborator

Replaced by #1737

@tlaurion tlaurion closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants