Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xx20/xx30/qemu q35/xx4x : coreboot 4.22.01 -> 24.02.01 VERSION BUMP + defconfig unification to oldconfig #1723

Commits on Jul 26, 2024

  1. coreboot 24.02.01: add upstream pending patches for heap allocation f…

    …ailure on bootsplash and defaulting to 4mb of heap when bootsplash
    
    Add upstreeam patches to downstream:
    git fetch https://review.coreboot.org/coreboot refs/changes/75/83475/1 && git format-patch -1 --stdout FETCH_HEAD > 0001-prevent_bootsplash_heap_allocation_failure_to_booting.patch
    git fetch https://review.coreboot.org/coreboot refs/changes/76/83476/2 && git format-patch -1 --stdout FETCH_HEAD > 0002-increase_heap_from1mb_to4mb_when_bootpslash_enabled.patch
    
    Rebuilding coreboot version with patches applied:
    docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:v0.2.0 -- make BOARD=qemu-coreboot-whiptail-tpm1 real.remove_canary_files-extract_patch_rebuild_what_changed
    Remove file added by patch when patching fails:
    sudo rm build/x86/libgpg-error-1.46/src/syscfg/lock-obj-pub.powerpc64le-unknown-linux-musl.h
    
    Applying patches touching coreboot version 24.02.01 defiend in board config to all boards:
    grep -R 24.02.01 boards/ | awk -F "/" {'print $2'} | while read board; do sudo make BOARD=$board coreboot.save_in_oldconfig_format_in_place; done
    
    Adding added/modified files to git tracked files for commit:
    git status | grep -e modified -e added | awk -F ":" {'print $2'}| xargs git add
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    119cebc View commit details
    Browse the repository at this point in the history
  2. modules/coreboot: add 24.02.01 version

    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f29c16d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    646db06 View commit details
    Browse the repository at this point in the history
  4. config/coreboot*: save new coreboot 24.02.01 coreboot configs in oldc…

    …onfig (see new defaults from 4.22.01)
    
    grep -R 24.02.01 boards/ | awk -F "/" {'print $2'} | while read board; do sudo make BOARD=$board coreboot.save_in_oldconfig_format_in_place; done
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6e237d9 View commit details
    Browse the repository at this point in the history
  5. CircleCI: modify comments/cache relative to version bump 4.22.01->24.…

    …02.01
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b8a87ff View commit details
    Browse the repository at this point in the history
  6. coreboot configs: put in defconfig to ease comparison and unification…

    … of configs
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    88cec3a View commit details
    Browse the repository at this point in the history
  7. coreboot configs: add CONFIG_COLLECT_TIMESTAMPS

    sed -i '/# CONFIG_COLLECT_TIMESTAMPS is not set/d' config/*.config
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    38bd342 View commit details
    Browse the repository at this point in the history
  8. coreboot configs: add CONFIG_RESOURCE_ALLOCATION_TOP_DOWN

    sed -i '/# CONFIG_RESOURCE_ALLOCATION_TOP_DOWN is not set/d' config/*.config
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d44fe53 View commit details
    Browse the repository at this point in the history
  9. coreboot configs: add CONFIG_USBDEBUG

    sed -i '$a CONFIG_USBDEBUG=y' config/coreboot-*.config
    grep -R CONFIG_COREBOOT_VERSION boards/ | awk -F "/" {'print $2'} | while read board; do if ! sudo make BOARD=$board coreboot.save_in_defconfig_format_in_place > /dev/null 2>&1; then echo $board failed;fi; done
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    446c98a View commit details
    Browse the repository at this point in the history
  10. coreboot configs: add CONFIG_DRIVERS_INTEL_WIFI

    This is needed so that ACPI tables are generated from coreboot for final OS to not apply quirks to support wifi cards
    
    TODO: bluethooth not activated here, maybe we should.
    
    sed -i '/# CONFIG_DRIVERS_INTEL_WIFI is not set/d' config/coreboot-*.config
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    296772a View commit details
    Browse the repository at this point in the history
  11. coreboot configs: put back all maintained boards (boards/*)'s coreboo…

    …t configs in oldconfig format
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    df1e6d7 View commit details
    Browse the repository at this point in the history
  12. nv41/ns50 coreboot configs: unset 'CONFIG_RESOURCE_ALLOCATION_TOP_DOW…

    …N=y': turns nv41 into a brick under current used coreboot Dasharo fork
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2253f6f View commit details
    Browse the repository at this point in the history
  13. modules/coreboot: Reuse 24.02.01 toolchain for coreboot-purism

    Reuse the toolchain from coreboot-24.02.01 for coreboot-purism (based
    on 24.02.01) instead of compiling a separate toolchain.
    
    Signed-off-by: Jonathon Hall <[email protected]>
    JonathonHall-Purism authored and tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d20333f View commit details
    Browse the repository at this point in the history
  14. coreboot configs: unify turning CONFIG_USBDEBUG off

    sed -i '$a CONFIG_USBDEBUG=n' config/coreboot-*.config
    grep -R CONFIG_COREBOOT_VERSION boards/ | awk -F "/" {'print $2'} | while read board; do if ! sudo make BOARD=$board coreboot.save_in_oldconfig_format_in_place  > /dev/null 2>&1; then echo $board failed;fi; done
    
    Note:
    Boards that are unmaintained accumulates settings addition per the sed call.
    
    Why deactivate:
    - Well, this is equivalent of cbmem -c which gives way too much information from attacker.
    
    TODO: add an helper later on so that builds aimed at testing coreboot version bump pass to release mode or something.
    
    As of this commit, we accept that bricks might happen and that troubleshooting will be made in a case basis?!
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    acc6493 View commit details
    Browse the repository at this point in the history
  15. BOARD_TESTERS.md: Add known board owners with external programmer (te…

    …sters)
    
    Those are currently known to be willing testers of coreboot/linux version bumps PRs to not cause bricks under Heads master
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    549c2e4 View commit details
    Browse the repository at this point in the history
  16. t530(-hotp)-maximized: move+ rename to boards/* + unify with x230-max…

    …imized boards for 24.02.01 + add Makefile helper + add back to CircleCI
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    cf9d10a View commit details
    Browse the repository at this point in the history
  17. w541: rename/move board flavors to UNTESTED since untested for corebo…

    …ot 24.02.01 version bumped and no news from expected board testers in time for merge
    
    Replication notes:
    - w541-hotp-maximized is a makefile inclusion of w541-maximized so order of ops is important
    
    docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:v0.2.1 -- make -d BOARD=w541-hotp-maximized board.move_tested_to_untested
    time docker run -e DISPLAY=$DISPLAY --network host --rm -ti -v $(pwd):$(pwd) -w $(pwd) tlaurion/heads-dev-env:v0.2.1 -- make -d BOARD=w541-maximized board.move_tested_to_untested
    git status
    git add boards/UNTESTED_w541-hotp-maximized/UNTESTED_w541-hotp-maximized.config boards/UNTESTED_w541-maximized/UNTESTED_w541-maximized.config boards/w541-hotp-maximized/w541-hotp-maximized.config boards/w541-maximized/w541-maximized.config .circleci/config.yml
    git commit --signoff
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1b6d26a View commit details
    Browse the repository at this point in the history
  18. boards/UNTESTED_w541-hotp-maximized/UNTESTED_w541-hotp-maximized.conf…

    …ig: Path is hardcoded to non hotp variant inclusion...
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d0b0eef View commit details
    Browse the repository at this point in the history
  19. config/coreboot-*: Turn off WIFI support in coreboot. If regression, …

    …will turn on case by case.
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a9e6dfe View commit details
    Browse the repository at this point in the history