Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP: FB_EFI (EFIFB kernel module's framebuffer on top of libgfxinit or GOP) next steps related cleanups #1522

Merged
merged 12 commits into from
Dec 12, 2023

Commits on Nov 20, 2023

  1. FB_EFI next step: remove CONFIG_BOOT_KERNEL_ADD=intel_iommu=on intel_…

    …iommu=igfx_off, add CONFIG_BOOT_KERNEL_REMOVE=intel_iommu=on intel_iommu=igfx_off, remove quiet removal from CONFIG_BOOT_KERNEL_REMOVE. TLDR: do not interfere with OS setting its own boot policies
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2fcef4a View commit details
    Browse the repository at this point in the history
  2. FB_EFI next step: remove coreboot's Heads linux intel_iommu statement…

    …s. TODO: check linux config to see if enabling automatically works as expected.
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f4a5a7c View commit details
    Browse the repository at this point in the history
  3. FB_EFI next step: make sure CONFIG_INTEL_IOMMU_DEFAULT_ON=y is on on …

    …all intel boards touched in past commit
    
    Touches c216, x230-flash, x230-legacy and x230-maximized.
    TODO: Other boards, including AMD ones (qemu/kgpe) have this ON, including nv41/ns50 (which uses i915drm which most probably causes problems)
     Note that qemu boards use q35 in config, but were made to have both i440fx and q35, where q35 is tested, which explains why its on by default there.
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    72e8c39 View commit details
    Browse the repository at this point in the history
  4. kgpe-d16 linux configs: remove Intel related stuff, enable AMD relate…

    …d IOMMU settings
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    6f276a3 View commit details
    Browse the repository at this point in the history
  5. Adapt NV41/NS50 changes, unify bootsplash file usage for branding

    Taken from : https://github.com/Nitrokey/heads/tree/temp-release-v2.3
    
    - Move branding/Heads/bootsplash-1024x768.jpg -> branding/Heads/bootsplash.jpg (We don't care about the size. Make filename generic)
    - Adapt all coreboot configs so bootsplash is adapted by BRAND_NAME CONFIG_BOOTSPLASH_FILE="@BRAND_DIR@/bootsplash.jpg"
      - Reminders :
        - Makefile changes Heads to defined BRAND_NAME in board config
        - Makefile changes -e 's!@BRAND_DIR@!$(pwd)/branding/$(BRAND_NAME)!g'
    - nv41/nv50
      - coreboot oldefconfigs adapted by:
        - make BOARD=nitropad-ns50 coreboot.modify_and_save_oldconfig_in_place
        - make BOARD=nitropad-nv41 coreboot.modify_and_save_oldconfig_in_place
      - linux oldefconfigs adapted by
        - make BOARD=nitropad-nv41 linux.modify_and_save_oldconfig_in_place
          - since this is shared config across nv41/ns50: it only needs to be done for a single board
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0f0cb99 View commit details
    Browse the repository at this point in the history
  6. coreboot configs: unify linux console output to 'quiet loglevel=2' bu…

    …t for qemu/flash boards
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7433920 View commit details
    Browse the repository at this point in the history
  7. linux config: oldconfig for all, make sure BRAND_NAME is there to be …

    …overriden
    
    TODO: linuxboot still not touched...
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b1f1484 View commit details
    Browse the repository at this point in the history
  8. x230-legacy-flash board: fixup pointing to x230 as opposed to t430. F…

    …ix coreboot config path to bootsplash
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0e42833 View commit details
    Browse the repository at this point in the history
  9. Changeset based on nitrokey 2.3 release to understand what is attempt…

    …ed here. i915 is still under linux config on 2.3 release. coreboot is on gop, not libgfxinit. This is to open discussion.
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    664603c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. nv41/nv51: add patch for efifb being able to drive libgfxinit/gop dri…

    …ven fb
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a7fe284 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Move t530, p8z77 and t420 boards to be prefixed with UNTESTED as per l…

    …inuxboot#1522 (comment). Note that w530 was already marked as UNTESTED, look for commit having moved this board as untested.
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0dbbae5 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. NV41: adapt board config to remove CONFIG_BOOT_KERNEL_ADD=intel_iommu…

    …=igfx_off equally as for NS50 under 2fcef4a and tested for NS50 at linuxboot#1522 (comment)
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e0fabb1 View commit details
    Browse the repository at this point in the history