Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Thinkpad W541 #1430

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Support Thinkpad W541 #1430

merged 1 commit into from
Oct 30, 2023

Conversation

gaspar-ilom
Copy link
Contributor

allows building heads for the w541 based on the t440p which has a sufficiently similar architecture.

I tested this with my the blobs from the test board and did not encounter any issues so far.

@tlaurion
Copy link
Collaborator

tlaurion commented Jul 4, 2023

@gaspar-ilom please duplicate config from either x230 or t440p under .circleci/config.yml

Board needs to build first prior of code review.

@tlaurion
Copy link
Collaborator

tlaurion commented Jul 5, 2023

@gaspar-ilom Also test 5.10.5 config that just got merged and rebase please

@tlaurion
Copy link
Collaborator

You might want to rebase on master, lots of changes happened.
Also address previous comments so CircleCI builds which you should test outcome and confirm working.

@gaspar-ilom thanks!

@gaspar-ilom
Copy link
Contributor Author

Thanks for you reply. I will do that. Unfortuantely, it will take some time as I am currently quite busy.

@tlaurion tlaurion marked this pull request as draft July 24, 2023 23:22
@gaspar-ilom gaspar-ilom force-pushed the w541-support branch 2 times, most recently from 060d724 to b289577 Compare October 13, 2023 10:21
@gaspar-ilom
Copy link
Contributor Author

gaspar-ilom commented Oct 14, 2023

I rebased, added the circleci config and tested the hotp build on the device. I did not encounter any issues yet. Also, I added the blobs which are extracted from the original rom on my board. I set the MAC address in both gbe.bin parts to 00:de:ad:c0:ff:ee using nvmutil.

Please take a look at the code and let me know which changes I should make. I copied most of the config from the 440p. However, I am not sure, what is your preferred way to manage such shared configs. So if there is some documentation you can refer me to I would appreciate it.

If preferred I can also squash the branch to a single commit.

@gaspar-ilom gaspar-ilom marked this pull request as ready for review October 14, 2023 19:32
@gaspar-ilom gaspar-ilom removed their assignment Oct 16, 2023
@gaspar-ilom
Copy link
Contributor Author

I rebased, added the circleci config and tested the hotp build on the device. I did not encounter any issues yet. Also, I added the blobs which are extracted from the original rom on my board. I set the MAC address in both gbe.bin parts to 00:de:ad:c0:ff:ee using nvmutil.

Please take a look at the code and let me know which changes I should make. I copied most of the config from the 440p. However, I am not sure, what is your preferred way to manage such shared configs. So if there is some documentation you can refer me to I would appreciate it.

If preferred I can also squash the branch to a single commit.

I did just squash the branch

@tlaurion
Copy link
Collaborator

Duplicate of #1500?

@gaspar-ilom
Copy link
Contributor Author

gaspar-ilom commented Oct 23, 2023

Duplicate of #1500?

Yes, both PRs are pretty much the same. This one is rebased on master, is the main difference. I would love to see either PR merged into master. What needs to be fixed for that to happen?

@tlaurion
Copy link
Collaborator

tlaurion commented Oct 24, 2023

@gaspar-ilom I will review tomorrow thoroughly.

Edit : well. This week, sorry.

@tlaurion
Copy link
Collaborator

Note:
@resende-gustavo and @gaspar-ilom owners of board to be added under #692

@tlaurion tlaurion merged commit f540f2a into linuxboot:master Oct 30, 2023
50 checks passed
@gaspar-ilom gaspar-ilom deleted the w541-support branch November 1, 2023 19:21
@tlaurion
Copy link
Collaborator

tlaurion commented Nov 5, 2023

Added missing librem boards in op

@tlaurion
Copy link
Collaborator

tlaurion commented Nov 5, 2023

Added @resende-gustavo and @gaspar-ilom as w541 board owners in op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants