Skip to content

Commit

Permalink
Support branding under branding subdirectories
Browse files Browse the repository at this point in the history
- Move logos and bootsplashes from blobs to branding/Heads/
- Makefile: add support for BRAND_DIR which depends on BRAND_NAME which defaults to Heads if undefined
- Boards coreboot configs: change bootsplash directory to depend on BRAND_DIR
- branding/Heads/bootsplash-1024x768.jpg points to branding/Heads/d-wid-ThePlexus_coreboot-linuxboot-heads_background-plain_DonateQrCode.jpg

Notes to d-wid:
- @d-wid: the xcf has to go. We cannot add 4mb of binary data in repo that might get deleted in the future
- I propose this naming scheme so that credit are clear directly in filenames, where commit shoud say that bing is original author as previously stated under #1451
- I'm not sure what online dev environement can do and cannot in terms of commit modifications. You seems to have been able to squash all prior commits. What is missing now would be properly credit Bing, ThrillerAtPlay and ThePlexus in your commit for the releative filenames and that would be good to go.
- I would then recreate a PR based on your PR, add Makefile magic and modify all coreboot configs to be aligned with qemu config as under this commit
  • Loading branch information
tlaurion committed Oct 2, 2023
1 parent d092125 commit b0e8eec
Show file tree
Hide file tree
Showing 14 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ FORCE:
define install_config =
sed -e 's!@BOARD_BUILD_DIR@!$(board_build)!g' \
-e 's!@BLOB_DIR@!$(pwd)/blobs!g' \
-e 's!@BRAND_DIR@!$(pwd)/branding/$(BRAND_NAME)!g' \
-e 's!@BRAND_NAME@!$(BRAND_NAME)!g' \
"$1" > "$2"
endef
Expand Down
1 change: 0 additions & 1 deletion blobs/bootsplash-1024x768.jpg

This file was deleted.

File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
1 change: 1 addition & 0 deletions branding/Heads/bootsplash-1024x768.jpg
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
2 changes: 1 addition & 1 deletion config/coreboot-qemu-tpm1.config
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ CONFIG_NO_STAGE_CACHE=y
# CONFIG_CBMEM_STAGE_CACHE is not set
# CONFIG_UPDATE_IMAGE is not set
CONFIG_BOOTSPLASH_IMAGE=y
CONFIG_BOOTSPLASH_FILE="@BLOB_DIR@/bootsplash-1024x768.jpg"
CONFIG_BOOTSPLASH_FILE="@BRAND_DIR@/bootsplash-1024x768.jpg"
CONFIG_BOOTSPLASH_CONVERT=y
CONFIG_BOOTSPLASH_CONVERT_QUALITY=70
# CONFIG_BOOTSPLASH_CONVERT_RESIZE is not set
Expand Down

0 comments on commit b0e8eec

Please sign in to comment.