Skip to content

Commit

Permalink
Move boards/UNTESTED_* boards to untested_boards/UNMAINTAINED_*, remo…
Browse files Browse the repository at this point in the history
…ve them from CircleCI, add Makefile helper and document untested_boards/README.md

Signed-off-by: Thierry Laurion <[email protected]>
  • Loading branch information
tlaurion committed Mar 25, 2024
1 parent b91eaed commit 9fcd5f8
Show file tree
Hide file tree
Showing 31 changed files with 31 additions and 120 deletions.
135 changes: 15 additions & 120 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -286,55 +286,20 @@ workflows:
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t520-hotp-maximized
target: UNTESTED_t520-hotp-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: t420-maximized
target: t420-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t520-maximized
target: UNTESTED_t520-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: x230-legacy-flash
target: x230-legacy-flash
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t430-legacy-flash
target: UNTESTED_t430-legacy-flash
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t430-legacy
target: UNTESTED_t430-legacy
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t430-hotp-legacy
target: UNTESTED_t430-hotp-legacy
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: x230-legacy
target: x230-legacy
Expand Down Expand Up @@ -384,83 +349,27 @@ workflows:
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t530-hotp-maximized
target: UNTESTED_t530-hotp-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t530-dgpu-hotp-maximized
target: UNTESTED_t530-dgpu-hotp-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: w530-hotp-maximized
target: w530-hotp-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_w530-dgpu-K1000m-hotp-maximized
target: UNTESTED_w530-dgpu-K1000m-hotp-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_w530-dgpu-K2000m-hotp-maximized
target: UNTESTED_w530-dgpu-K2000m-hotp-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: t430-maximized
target: t430-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t530-maximized
target: UNTESTED_t530-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_t530-dgpu-maximized
target: UNTESTED_t530-dgpu-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: w530-maximized
target: w530-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_w530-dgpu-K1000m-maximized
target: UNTESTED_w530-dgpu-K1000m-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_w530-dgpu-K2000m-maximized
target: UNTESTED_w530-dgpu-K2000m-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: t440p-maximized
target: t440p-maximized
Expand Down Expand Up @@ -510,20 +419,6 @@ workflows:
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_p8z77-m_pro-tpm1-maximized
target: UNTESTED_p8z77-m_pro-tpm1-maximized
subcommand: ""
requires:
- x230-hotp-maximized

- build:
name: UNTESTED_p8z77-m_pro-tpm1-hotp-maximized
target: UNTESTED_p8z77-m_pro-tpm1-hotp-maximized
subcommand: ""
requires:
- x230-hotp-maximized

#coreboot-git librem boards
- build:
name: librem_13v2
Expand Down Expand Up @@ -576,25 +471,25 @@ workflows:
- nitropad-nv41

# - build:
# name: UNTESTED_kgpe-d16_workstation-usb_keyboard
# target: UNTESTED_kgpe-d16_workstation-usb_keyboard
# name: UNMAINTAINED_kgpe-d16_workstation-usb_keyboard
# target: UNMAINTAINED_kgpe-d16_workstation-usb_keyboard
# subcommand: ""
# requires:
# - UNTESTED_kgpe-d16_workstation
# - UNMAINTAINED_kgpe-d16_workstation

# - build:
# name: UNTESTED_kgpe-d16_server
# target: UNTESTED_kgpe-d16_server
# name: UNMAINTAINED_kgpe-d16_server
# target: UNMAINTAINED_kgpe-d16_server
# subcommand: ""
# requires:
# - UNTESTED_kgpe-d16_workstation
# - UNMAINTAINED_kgpe-d16_workstation

# - build:
# name: UNTESTED_kgpe-d16_server-whiptail
# target: UNTESTED_kgpe-d16_server-whiptail
# name: UNMAINTAINED_kgpe-d16_server-whiptail
# target: UNMAINTAINED_kgpe-d16_server-whiptail
# subcommand: ""
# requires:
# - UNTESTED_kgpe-d16_workstation
# - UNMAINTAINED_kgpe-d16_workstation

# - build:
# name: librem_l1um
Expand All @@ -611,24 +506,24 @@ workflows:
# linuxboot steps need something to pass in the kernel header path
# skipping for now
# - run:
# name: UNTESTED_qemu-linuxboot-edk2
# name: UNMAINTAINED_qemu-linuxboot-edk2
# command: |
# ./build/make-4.2.1/make \
# CROSS=/cross/bin/x86_64-linux-musl- \
# BOARD=UNTESTED_qemu-linuxboot \
# BOARD=UNMAINTAINED_qemu-linuxboot \
# `/bin/pwd`/build/linuxboot-git/build/qemu/.configured \
# # Run first to avoid too many processes
#
# - run:
# name: UNTESTED_qemu-linuxboot
# name: UNMAINTAINED_qemu-linuxboot
# command: |
# ./build/make-4.2.1/make \
# CROSS=/cross/bin/x86_64-linux-musl- \
# CPUS=16 \
# V=1 \
# BOARD=UNTESTED_qemu-linuxboot \
# BOARD=UNMAINTAINED_qemu-linuxboot \
#
# - store-artifacts:
# path: build/UNTESTED_qemu-linuxboot/linuxboot.rom
# path: build/UNMAINTAINED_qemu-linuxboot/linuxboot.rom
# - store-artifacts:
# path: build/UNTESTED_qemu-linuxboot/hashes.txt
# path: build/UNMAINTAINED_qemu-linuxboot/hashes.txt
12 changes: 12 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,18 @@ board.move_untested_to_tested:
echo "Replacing $$BOARD with $$NEW_BOARD in .circleci/config.yml"; \
sed -i "s/$$BOARD/$$NEW_BOARD/g" .circleci/config.yml

board.move_untested_to_unmaintained:
@echo "NEW_BOARD variable will move from UNTESTED_ to UNMAINTAINED_ from $(BOARD)"
@NEW_BOARD=$$(echo $(BOARD) | sed 's/^UNTESTED_/UNMAINTAINED_/g'); \
echo "Renaming boards/$$BOARD/$$BOARD.config to boards/$$BOARD/$$NEW_BOARD.config"; \
mkdir -p unmaintained_boards; \
mv boards/$$BOARD/$$BOARD.config unmaintained_boards/$$BOARD/$$NEW_BOARD.config; \
echo "Renaming boards/$$BOARD to unmaintainted_boards/$$NEW_BOARD"; \
rm -rf boards/$$NEW_BOARD; \
mv boards/$$BOARD unmaintained_boards/$$NEW_BOARD; \
echo "Replacing $$BOARD with $$NEW_BOARD in .circleci/config.yml. Delete manually entries"; \
sed -i "s/$$BOARD/$$NEW_BOARD/g" .circleci/config.yml

board.move_tested_to_untested:
@echo "NEW_BOARD variable will add UNTESTED_ prefix to $(BOARD)"
@NEW_BOARD=UNTESTED_$(BOARD); \
Expand Down
4 changes: 4 additions & 0 deletions unmaintained_boards/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Boards under this directory were moved from UNTESTED_ to UNMAINTAINED_ automatically since untested for a while.
Boards not having UNMAINTAINED in their names are not compliant with current build system (linuxboot) and need reupstreaming.

To test those boards, move them to boards directory and follow normal build operations, test builds on boards and open an issue stating you are willing to test those when builds are made available from CircleCI in the future.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 9fcd5f8

Please sign in to comment.