add a display command. #436
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 41.63% 41.46% -0.18%
==========================================
Files 142 143 +1
Lines 10728 10775 +47
==========================================
+ Hits 4467 4468 +1
- Misses 5393 5438 +45
- Partials 868 869 +1 ☔ View full report in Codecov by Sentry. |
rminnich
force-pushed
the
displaycommand
branch
from
b05579c
to
45cd859
Compare
|
|
|
And, yeah, note, they all look the same. Still not sure why. |
Can you dump the intermediate states to files and just |
rminnich
force-pushed
the
displaycommand
branch
from
6df8aef
to
faca115
Compare
|
just tried this myself, with an empty list, expecting all the DXEs to go down the drain - which should result in a big change, but it looks the same |
The display command uses the plan9ports devdraw device, and the 9fans devdraw Go support, to allow a display of the state of the buffer. Currently, a user can do something like this: Set up so devdraw command is in $PATH PLAN9=/Users/rminnich/Documents/plan9 export PLAN9 PATH=$PATH:$PLAN9/bin export PATH Now run utk utk ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom \ display start \ remove_dxes_except list \ display end The result will be two windows, one showing before, and one after. The plan is that this can get fancier: utk ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom \ display start \ remove Http.* \ display nohttp \ remove_dxes_except list \ display end Also, note, although we only set up one pixel for each point, devdraw is nice to you: if you grow the window it grows the display of ROM. Also, the border is necessery for OSX with its rounded edges. But: it's still not drawing the image correctly. Me and graphics. Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Waiting for someone who is good at this to fix it. Signed-off-by: Ronald G. Minnich <[email protected]>
rminnich
force-pushed
the
displaycommand
branch
from
8efc86a
to
e49e2ff
Compare
|
@rminnich here is a fixup for the rendering rminnich#1 |
|
it looks like the issue is with the |
The display command uses the plan9ports devdraw device, and the 9fans devdraw Go support, to allow a display of the state of the buffer.
Currently, a user can do something like this:
Set up so devdraw command is in $PATH
PLAN9=/Users/rminnich/Documents/plan9 export PLAN9 PATH=$PATH:$PLAN9/bin export PATH
Now run utk
utk ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom
display start
remove_dxes_except list
display end
The result will be two windows, one showing before, and one after.
The plan is that this can get fancier:
utk ~/Downloads/SBIOS_P5043_PG535_SKU_893_02.02.03_rel_prod.rom
display start
remove Http.*
display nohttp
remove_dxes_except list
display end
Also, note, although we only set up one pixel for each point, devdraw is nice to you: if you grow the window it grows the display of ROM. Also, the border is necessery for OSX with its rounded edges.