Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #422

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Update README.md #422

merged 1 commit into from
Sep 17, 2024

Conversation

bsdimp
Copy link
Contributor

@bsdimp bsdimp commented Sep 13, 2024

go requires a version number for go install commands, so add @latest to the commands.

@orangecms
Copy link
Collaborator

Thank you! Could you please do a sign-off? 😬

Just git commit --amend -s will do, and then git push -f :)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.63%. Comparing base (b3968fa) to head (a7025cb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   41.63%   41.63%           
=======================================
  Files         142      142           
  Lines       10729    10729           
=======================================
  Hits         4467     4467           
  Misses       5394     5394           
  Partials      868      868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go requires a version number for `go install` commands, so add @latest to the commands.

Signed-off-by: Warner Losh <[email protected]>
@bsdimp
Copy link
Contributor Author

bsdimp commented Sep 17, 2024

Thank you! Could you please do a sign-off? 😬

Just git commit --amend -s will do, and then git push -f :)

You bet.

@bsdimp
Copy link
Contributor Author

bsdimp commented Sep 17, 2024

Anything else?

Copy link
Collaborator

@orangecms orangecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, that's it - thanks a ton! :)

@orangecms orangecms merged commit 17b6cb3 into linuxboot:main Sep 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants