feat(uefi): Add workaround SuppressErasePolarityError #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are real production firmwares with mixed erase polarity. To possibility to parse such firmwares, adding an option to ignore the error of conflicting erase polarities. Signed-off-by: Dmitrii Okunev <[email protected]>
ChriMarMe
approved these changes
Jan 23, 2023
Codecov ReportBase: 42.20% // Head: 42.20% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
=======================================
Coverage 42.20% 42.20%
=======================================
Files 125 125
Lines 8978 8978
=======================================
Hits 3789 3789
Misses 4484 4484
Partials 705 705
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are real production firmwares with mixed erase polarity. To possibility to parse such firmwares, adding an option to ignore the error of conflicting erase polarities.
ITS: #329
Feel free to reject this PR.