WIP: debug FV assembly

Signed-off-by: Daniel Maslowski <[email protected]>
linuxboot · Sep 28, 2024 · cbe3614 · cbe3614
1 parent df71279
commit cbe3614
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/uefi/firmwarevolume.go b/pkg/uefi/firmwarevolume.go
@@ -165,7 +165,11 @@ func (fv *FirmwareVolume) InsertFile(alignedOffset uint64, fBuf []byte) error {
 	// Check size
 	fLen := uint64(len(fBuf))
 	if fLen == 0 {
-		return errors.New("trying to insert empty file")
+		if true {
+			return nil
+		} else {
+			return errors.New("trying to insert empty file")
+		}
 	}
 	// Overwrite old data in the firmware volume.
 	fv.buf = append(fv.buf, fBuf...)

diff --git a/pkg/visitors/assemble.go b/pkg/visitors/assemble.go
@@ -80,8 +80,9 @@ func (v *Assemble) Visit(f uefi.Firmware) error {
 		for _, file := range f.Files {
 			fileBuf := file.Buf()
 			fileLen := uint64(len(fileBuf))
+			log.Warnf("adding %v ", file.Header.GUID)
 			if fileLen == 0 {
-				log.Fatalf("%v", file.Header.GUID)
+				log.Warnf("%v empty?", file.Header.GUID)
 			}
 
 			// Pad to the 8 byte alignments.