Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer.conf: Fix the syntax for SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS #157

Closed
wants to merge 3 commits into from

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Nov 13, 2019

Signed-off-by: Khem Raj [email protected]

@kraj
Copy link
Contributor Author

kraj commented Nov 26, 2019

ping ?

@@ -0,0 +1,54 @@
From ba4cc0d7b08efecd2b2bfb04c7a70187d7056304 Mon Sep 17 00:00:00 2001
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this patch would better go directly to https://github.com/linux4sam/libplanes . What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already done linux4sam/libplanes#3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can merge the first commit while the pull request on libplanes gets accepted...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, we need the second commit for it to work with master OE-Core/yocto since py2 is being thrown out next week. So I would suggest taking both. If libplane commit requires changes after review, I will update the patch here as well accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make more tests with python3 and see if everything is fine, so I will postpone your pull request until then.

@kraj kraj force-pushed the yoe/mut branch 3 times, most recently from 4bf292d to 6827131 Compare December 4, 2019 16:26
@kraj
Copy link
Contributor Author

kraj commented Dec 4, 2019

I have updated this pull request on latest zeus/master changes, please review and merge

kraj added 2 commits December 18, 2019 09:26
Python2 is on its way out in Jan 2020

Signed-off-by: Khem Raj <[email protected]>
kplot otherwise has runtime check for this, which fails when building
for say x86, since build host is also x86 it is able to run the runtime
testcode on build machine, but thats wrong, it should be either run
using qemu or not run at all, here we use configure time check to detect
reallocarray()

Signed-off-by: Khem Raj <[email protected]>
@kraj
Copy link
Contributor Author

kraj commented Dec 19, 2019

I am closing this pull since its partially merged, I will open another one which lists still pending patches

@kraj kraj closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants