Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): version 1.6.1 [citest skip] #171

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

spetrosi
Copy link
Contributor

@spetrosi spetrosi commented Apr 2, 2024

Update changelog and .README.html for version 1.6.1

Signed-off-by: Sergei Petrosian [email protected]

@spetrosi spetrosi requested review from richm and ptoscano as code owners April 2, 2024 16:24
@ptoscano
Copy link
Collaborator

ptoscano commented Apr 3, 2024

@spetrosi not sure whether you noticed these failures in the ansible test:

ERROR: docs/CHANGELOG_rhc.md:24:128: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: roles/rhc/CHANGELOG.md:24:128: use ASCII quotes `'` and `"` instead of Unicode quotes

@richm
Copy link
Contributor

richm commented Apr 3, 2024

@spetrosi not sure whether you noticed these failures in the ansible test:

ERROR: docs/CHANGELOG_rhc.md:24:128: use ASCII quotes `'` and `"` instead of Unicode quotes
ERROR: roles/rhc/CHANGELOG.md:24:128: use ASCII quotes `'` and `"` instead of Unicode quotes

Yes - that's bad - needs to be fixed - not sure how Result: Consistently with a similar condition of the display_name parameter, an empty string ansible_host is treated as undefined. It’s the same behavior as with a null value. got added with the unicode quote mark

@ptoscano
Copy link
Collaborator

ptoscano commented Apr 3, 2024

It's the text of the PR #169. I just edited it to switch the apostophe to an ASCII character, so would you please try to run the release automation again?

Update changelog and .README.html for version 1.6.1

Signed-off-by: Sergei Petrosian <[email protected]>
@spetrosi
Copy link
Contributor Author

spetrosi commented Apr 3, 2024

ansible-test is more and more strict. I've modified changelog entry.

@ptoscano ptoscano merged commit b4e0da7 into linux-system-roles:main Apr 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants