Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source path to the actual role folder #358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change source path to the actual role folder #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ def role_to_collection(
"--role",
rolename,
"--src-path",
args.src_path,
os.path.join(args.src_path, rolename),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src_path can be either the parent directory of the role, or the role directory. Forcing it to be only the role directory will break some of our use cases.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richm Okay - so what be an acceptable solution then? The only other thing that currently comes to my mind is, to checkout remote roles to individual tmp folders. As you can see in the provided error log in the issue #357 you code currently picks up the wrong folder on the second cloned repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhenkel What repo(s) are release_collection.py checking out from github? What does your collection_release.yml look like?

Copy link
Author

@hhenkel hhenkel Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this, it is a enterprise github:

usergroups:
  org: Github-My_corp-CHE
  repo: cioapir-my_corp.ansible-role-usergroups
  ref: 0.0.0
  sourcenum: 1
users:
  org: Github-My_corp-CHE
  repo: cioapir-my_corp.ansible-role-users
  ref: 0.0.0
  sourcenum: 2
sudo:
  org: Github-My_corp-CHE
  repo: cioapir-my_corp.ansible-role-sudo
  ref: 0.0.0
  sourcenum: 3

"--dest-path",
args.dest_path,
"--namespace",
Expand Down