nvme: add NVMe 2.1 changed-alloc-ns-list-log command #2675
Conversation
|
Note: Just realized to add the alloc option into the existing the changed-ns-list-log command instead of to add the changed-alloc-ns-list-log command. |
nvme-wrap.c
Outdated
| { | ||
| if (alloc) | ||
| return nvme_get_log_changed_alloc_ns_list(dev->direct.fd, rae, len, ns_log); |
There was a problem hiding this comment.
I suppose the do_admin_op wrapper should be used here as well. Do we miss an API update in libnvme-mi?
There was a problem hiding this comment.
Yes sorry for the missing so will update libnvme-mi to add APIs later. Thank you.
There was a problem hiding this comment.
Please introduce a new wrapper function for nvme_get_log_changed_alloc_ns_list. These function here should really only switch between the standard API and MI API interfaces. There should be no logic besides this. Note, these wrappers will go away when we start with libnvme 2.x hopefully soonish.
There was a problem hiding this comment.
Understood and noted then fixed the changes as so. Thank you.
ikegami-t
force-pushed
the
alloc-ns-list
branch
from
6a8f3ef to
3ed2208
Compare
ikegami-t
force-pushed
the
alloc-ns-list
branch
from
3ed2208 to
e990244
Compare
|
Rebased and fixed the conflict errors. |
ikegami-t
force-pushed
the
alloc-ns-list
branch
2 times, most recently
from
7afee19 to
79984d5
Compare
Return error for the missing get log rotational media function for non MI devices. Signed-off-by: Tokunori Ikegami <[email protected]>
The command functions combined with the changed-ns-list-log command. The output almost same but different as lists attached or allocated NSs. Signed-off-by: Tokunori Ikegami <[email protected]>
Added the nvme-changed-alloc-ns-list-log.txt file. Signed-off-by: Tokunori Ikegami <[email protected]>
Since missed to add the command into the command list. Signed-off-by: Tokunori Ikegami <[email protected]>
Both bash and zsh completions updated for the command. Signed-off-by: Tokunori Ikegami <[email protected]>
|
dropped/splitted unrelated changes from the main patch. |
The command functions combined with the changed-ns-list-log command. The output almost same but different as lists attached or allocated NSs.