Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocp: fix telemetry string log output file handling #2609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Karthikmct
Copy link

ocp: fix telemetry string log output file handling

Fixed the code to avoid binary file creation by tool for ocp

Signed-off-by: Karthik [email protected]

@Karthikmct
Copy link
Author

@igaw , This fix is addressing your comment on get_c9_log_page_data in [https://github.com//pull/2586]

@igaw
Copy link
Collaborator

igaw commented Dec 10, 2024

This drops the support for the binary output into a file completely. I'd say it would be nice to get all the use cases properly working instead just dropping this feature. Someone might want to us it.

In nvme.c we have couple example how it could be done. get_log for example has the --raw-output argument. But that was introduces before we had the global --output-format=binary. Hmm, so I think the most canonical way would be to get --output-format=binary properly working for all commands in ocp and use the shell redirect to write into a file. For those commands which want to write the output into a file an additional command line argument could be added. I thinke we have this for the submit_io based command.

Anyway, my point is that I'd like to see the ocp plugin to adapt the same type of input/output handling pattern we have in the main code base. Having two different philosophy how to things is just confusing.

Fixed the code to avoid binary file creation by tool for ocp

Signed-off-by: Karthik Balan [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants