fabrics: Move duplicate code to libnvme #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-belanger
force-pushed
the
new-apis
branch
2 times, most recently
from
458eefd
to
ef940d3
Compare
igaw
reviewed
Sep 14, 2023
martin-belanger
force-pushed
the
new-apis
branch
from
ef940d3
to
b0f02c2
Compare
|
Just reordered the patches. |
added 2 commits
September 20, 2023 09:36
Signed-off-by: Martin Belanger <[email protected]>
nvme-cli will now use the new libnvme functions nvme_ctrl_find() and nvme_ctrl_config_match(). Signed-off-by: Martin Belanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing duplicate code and moving to libnvme. This nvme-cli patch depends on libnvme commit 18b3316c502f229a5339d2c283510ec8008ec3b9.
Depends-on: linux-nvme/libnvme#716
Some of the checks will fail until the above PR has been merged on libnvme.