-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvme-print: Add support for EGFEAT, Domain Identifier, TEGCAP and UEGCAP #2035
Conversation
static void binary_endurance_log(struct nvme_endurance_group_log *endurance_log, | ||
__u16 group_id, const char *devname) | ||
static void binary_endurance_log(struct nvme_endurance_group_log *endurance_log, __u16 group_id, | ||
const char *devname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated whitespace change
nvme_uint128_t data_units_written = le128_to_cpu(endurance_group->data_units_written); | ||
nvme_uint128_t media_units_written = le128_to_cpu(endurance_group->media_units_written); | ||
nvme_uint128_t host_read_cmds = le128_to_cpu(endurance_group->host_read_cmds); | ||
nvme_uint128_t host_write_cmds = le128_to_cpu(endurance_group->host_write_cmds); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these whitespace changes should be in a different patch. It really makes it hard to spot where
non whitespace changes are happening. And I am not sure if it's worth to update it anyway, it's not
that these lines are eye/checkpatch offending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split the whitespace changes as a separated patch and also fixed to add to print domain_identifier correctly.
Fetch EGFEAT, Domain Identifier, TEGCAP and UEGCAP changes. Signed-off-by: Daniel Wagner <[email protected]>
Signed-off-by: Tokunori Ikegami <[email protected]>
Signed-off-by: Tokunori Ikegami <[email protected]>
|
Sorry took a bit longer. Too much work... |
No description provided.