nvme-print: Add support for EGFEAT, Domain Identifier, TEGCAP and UEGCAP #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
requested changes
Aug 21, 2023
| static void binary_endurance_log(struct nvme_endurance_group_log *endurance_log, | ||
| __u16 group_id, const char *devname) | ||
| static void binary_endurance_log(struct nvme_endurance_group_log *endurance_log, __u16 group_id, | ||
| const char *devname) |
| nvme_uint128_t data_units_written = le128_to_cpu(endurance_group->data_units_written); | ||
| nvme_uint128_t media_units_written = le128_to_cpu(endurance_group->media_units_written); | ||
| nvme_uint128_t host_read_cmds = le128_to_cpu(endurance_group->host_read_cmds); | ||
| nvme_uint128_t host_write_cmds = le128_to_cpu(endurance_group->host_write_cmds); |
There was a problem hiding this comment.
All these whitespace changes should be in a different patch. It really makes it hard to spot where
non whitespace changes are happening. And I am not sure if it's worth to update it anyway, it's not
that these lines are eye/checkpatch offending
There was a problem hiding this comment.
Split the whitespace changes as a separated patch and also fixed to add to print domain_identifier correctly.
Fetch EGFEAT, Domain Identifier, TEGCAP and UEGCAP changes. Signed-off-by: Daniel Wagner <[email protected]>
Signed-off-by: Tokunori Ikegami <[email protected]>
Signed-off-by: Tokunori Ikegami <[email protected]>
|
igaw
approved these changes
Sep 4, 2023
|
Sorry took a bit longer. Too much work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.