nvme-print-stdout: List only ctrls which are part of ns #2008
Conversation
We should only list the controllers which are associated with the current namespace. Previously we added all controllers of the subsystem to the list. Fixes: a660c50 ("nvme-print-stdout: Support subsys reachable from several hosts") Signed-off-by: Daniel Wagner <[email protected]>
| @@ -4693,8 +4694,10 @@ static bool stdout_detailed_ns(const char *name, void *arg) | |||
| return true; | |||
| } | |||
|
|
|||
| nvme_subsystem_for_each_ctrl(nvme_ns_get_subsystem(n), c) | |||
| nvme_namespace_for_each_path(n, p) { | |||
There was a problem hiding this comment.
Looks good but to make sure let me confirm if is this worked for not multipath case also since the function nvme_namespace_for_each_path() is used to check multipath as below? (Seems for the not multipath case no controller listed if the function implementation correct.)
static bool nvme_is_multipath(nvme_subsystem_t s)
{
...
nvme_subsystem_for_each_ns(s, n)
nvme_namespace_for_each_path(n, p)
return true;
...
return false;
}There was a problem hiding this comment.
In the case of !multipath, nvme_ns_get_ctrl(n)) will return a valid pointer right above (ca. line 4691) and then we exit early the function.
This is due the fact !mutlipath devices and multipath devices have two different sysfs hierarchies.
There was a problem hiding this comment.
And what's worth, I've tested this for both scenarios
There was a problem hiding this comment.
Thanks for your explanations and confirmation. I could understand them.
We should only list the controllers which are associated with the current namespace. Previously we added all controllers of the subsystem to the list.
Fixes: a660c50 ("nvme-print-stdout: Support subsys reachable from several hosts")