Skip to content

Commit

Permalink
nvme-print: fix error information log page endianness error
Browse files Browse the repository at this point in the history
Convert the status and phase tag fields to native byte order at first.

Signed-off-by: Tokunori Ikegami <[email protected]>
  • Loading branch information
ikegami-t authored and igaw committed Sep 23, 2024
1 parent 2655980 commit c1fa24b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions nvme-print-json.c
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,8 @@ static void json_error_log(struct nvme_error_log_page *err_log, int entries,
obj_add_uint64(error, "error_count", le64_to_cpu(err_log[i].error_count));
obj_add_int(error, "sqid", le16_to_cpu(err_log[i].sqid));
obj_add_int(error, "cmdid", le16_to_cpu(err_log[i].cmdid));
obj_add_int(error, "status_field", le16_to_cpu(err_log[i].status_field >> 0x1));
obj_add_int(error, "phase_tag", le16_to_cpu(err_log[i].status_field & 0x1));
obj_add_int(error, "status_field", le16_to_cpu(err_log[i].status_field) >> 0x1);
obj_add_int(error, "phase_tag", le16_to_cpu(err_log[i].status_field) & 0x1);
obj_add_int(error, "parm_error_location",
le16_to_cpu(err_log[i].parm_error_location));
obj_add_uint64(error, "lba", le64_to_cpu(err_log[i].lba));
Expand Down
3 changes: 1 addition & 2 deletions nvme-print-stdout.c
Original file line number Diff line number Diff line change
Expand Up @@ -3664,8 +3664,7 @@ static void stdout_error_log(struct nvme_error_log_page *err_log, int entries,
printf("cmdid : %#x\n", err_log[i].cmdid);
printf("status_field : %#x (%s)\n", status,
nvme_status_to_string(status, false));
printf("phase_tag : %#x\n",
le16_to_cpu(err_log[i].status_field & 0x1));
printf("phase_tag : %#x\n", le16_to_cpu(err_log[i].status_field) & 0x1);
printf("parm_err_loc : %#x\n",
err_log[i].parm_error_location);
printf("lba : %#"PRIx64"\n",
Expand Down

0 comments on commit c1fa24b

Please sign in to comment.