ioctl: add nvme_get_egid_log() #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikegami-t
force-pushed
the
get-egid-log
branch
8 times, most recently
from
71bff73 to
97d333d
Compare
igaw
reviewed
Jan 7, 2025
igaw
reviewed
Jan 7, 2025
| .len = len, | ||
| .nsid = NVME_NSID_ALL, | ||
| .lsp = rgo, | ||
| .rae = rae, |
igaw
reviewed
Jan 7, 2025
igaw
reviewed
Jan 7, 2025
|
Looks all good. Just my comment on the timeout. |
|
The default timeout value is zero so not needed to set as initialized the variable args timeout as zero. Should we set the default value explicitly? Thank you. |
|
I see. Though it would be possible to set it and then some of the commands have value 0 and the test is something else. Let's follow the existing pattern. That makes it a bit more consistent. IIRC, this is also why the other not used fields in the existing commands are excplicitly set to 0 (e.g. |
This is to use for the endurance group scope log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
get-egid-log
branch
from
8a45c61 to
30bd194
Compare
|
Fixed the patch to set the timeout and other values unset before. I just understood again as before you mentioned for the nvme-cli commands config values as same. Thank you. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to use for the endurance group scope log page.