ioctl: Live Migration #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Dec 9, 2024
|
Rest looks good. Good we haven't released the |
Continues efforts from the newly minted TP4159 PCIe Infrastructure for Live Migration specification with new ioctls. Signed-off-by: Nate Thornton <[email protected]>
|
Appreciate your careful eye and thoughtful feedback through all of this! The changes are much better than my original set. The nvme-cli changes are next. |
|
Sure thing! Glad you took it not personal that I was picking on details, but I agree the result is way better :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues efforts from the newly minted TP4159 PCIe Infrastructure for Live Migration specification with new ioctls.
Same as #911 but adopts new types.h definitions from #913 and removes MOS derived arguments in favor of generic
mosfield. I figured this was more "future proof".