Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove symbol which doesn't exist in libnvme-mi.so #725

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

parona-source
Copy link
Contributor

Last unused symbol, 20a3fa8 cleaned up the rest in libnvme.so.

clang  -o src/libnvme-mi.so.1.6.0 src/libnvme-mi.so.1.6.0.p/nvme_cleanup.c.o src/libnvme-mi.so.1.6.0.p/nvme_log.c.o src/libnvme-mi.so.1.6.0.p/nvme_mi.c.o src/libnvme-mi.so.1.6.0.p/nvme_mi-mctp.c.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libnvme-mi.so.1 -O3 -pipe -march=znver3 -flto=thin -Wl,-O1 -Wl,--as-needed -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 ccan/libccan.a -Wl,--version-script=/var/tmp/portage/sys-libs/libnvme-1.6/work/libnvme-1.6/src/libnvme-mi.map /usr/lib64/libdbus-1.so -Wl,--end-group
ld.lld: error: version script assignment of 'LIBNVME_MI_1_1' to symbol 'nvme_mi_root_close' failed: symbol not defined
clang: error: linker command failed with exit code 1 (use -v to see invocation)

https://github.com/search?q=repo%3Alinux-nvme%2Flibnvme%20nvme_mi_root_close&type=code

Bug: https://bugs.gentoo.org/914635
Signed-off-by: Alfred Wingate [email protected]

* Added in bb70b87, but was never used.

Signed-off-by: Alfred Wingate <[email protected]>
@igaw igaw merged commit 303775a into linux-nvme:master Oct 10, 2023
13 checks passed
@igaw
Copy link
Collaborator

igaw commented Oct 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants