util: remove unused nvme_status_to_errno function #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this function is not used anymore related nvme-cli modification below linux-nvme/nvme-cli@9643090 linux-nvme/nvme-cli#2045 Signed-off-by: Steven Seungcheol Lee <[email protected]>
|
Unfortunately, we can't remove this function just because nvme-cli doesn't use it anymore. There might be other users of this function. We can remove it when we do a 2.x major version update of the library but for the 1.x branch we have to leave it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this function is not used anymore
related nvme-cli modification below
linux-nvme/nvme-cli@9643090 linux-nvme/nvme-cli#2045