Add MacOS support #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import elf.h file from: https://gist.github.com/mlafeldt/3885346 And use it :D Signed-off-by: Danila Tikhonov <[email protected]>
MarijnS95
reviewed
Jun 27, 2024
Comment on lines
+13
to
+17
| #if defined(__APPLE__) | ||
| #include "include/elf.h" | ||
| #else | ||
| #include <elf.h> | ||
| #endif |
There was a problem hiding this comment.
Everything else aside, it seems cleaner to add the local include folder to the search path from the makefile perhaps? And then rename the folder to indicate that it's a specific fallback for when the target doesn't provide elf.h.
lumag
requested changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not entirely sure if this is something we should officially support. I added it primarily for my own use since it was helpful to me on one occasion. However, it might also be useful to others