Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document: labs: kernel api: improve quality of the graph of list evolution #403

Closed
wants to merge 2 commits into from

Conversation

hanyujie2002
Copy link

This new png file is created with draw.io.

@lkt-bot
Copy link
Collaborator

lkt-bot commented May 10, 2024

@dbaluta
Copy link
Member

dbaluta commented May 10, 2024

This doesn't look right. We shouldn't have the merge commit.

@hanyujie2002
Copy link
Author

This doesn't look right. We shouldn't have the merge commit.

I apologize for that. Could you please point out what's wrong with me so that I can improve my pr?

image

The new png file looks nice in the preview

@dbaluta
Copy link
Member

dbaluta commented May 10, 2024

You should have only 1 git commit which adds the photo. I'm not sure how you created the commit but here how it looks on my side:

image

You should have only 1 commit, the second commit with "Merge... " shouldn't be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants