Bespin scala enhancement - Initial Pass #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re comments and make things a bit more idiomatic (the window calculations are not very 'scala-y' right now)
…more scala-idiomatic. Also added ported version of search code
…les and remove the need for explicit conversion from java
…tation - Basic page rank results match
moore-ryan
force-pushed
the
bespin-scala-enhancement
branch
from
4f7601d to
7e1b2c9
Compare
…source files from the internet before running
This should make the code a bit more modular and simple. It also solves some of the problems with the previous implementation having trouble with things such as running a simple partition job with no mapper or reducer being set. Addition of more integration tests and some unit tests for Hadoop<->Scala conversions
…ppers and reducers
|
This PR is for progress tracking only; I will close this PR, rebase, and open a new PR in order to avoid cluttering commit history later. |
Also added in an implicit conversion between String -> hadoop Path to make specification of inputs and outputs more like it is in Spark. Removed unused "compareJavaScala.py" file.
moore-ryan
force-pushed
the
bespin-scala-enhancement
branch
from
ed70182 to
494b2cb
Compare
Added integration tests for BFS, refactored other integration tests
…ug in scala PageRank related to strange iterator behavior.
Fixed bug in RunPageRankSchimmy that caused failures in local mode of IMC due to mapper reuse. Added integration tests for PageRank and PageRankSchimmy.
|
Closing this PR in favor of this PR, which is simply a squashed version of this commit. This should cut back on the commit history growth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial step of porting over more of the Bespin Java MapReduce code to Scala. It also includes the initial version of a small DSL (MapReduceSugar.scala) which allows for a more natural definition of MapReduce jobs in a type-safe manner.
This PR includes the Scala implementations of the Bigram count MapReduce programs. Output from the Scala implementation appears the same as the Java implementation, modulo some ordering differences in the "Stripes" implementation.