Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port in mysqlv2 resource #1748

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Fixed the bug that was causing port to show up as 0 in the state after creating a mysqlv2 resource. Also pointed to latest linodego release.

✔️ How to Test

The following steps assume you have pulled down this PR locally.

Unit Tests

make test-unit

Integration Tests

make test-int TEST_SUITE="databasemysqlv2"

Manual Tests

  1. In dx-devenv, run the following TF config:
 resource "linode_database_mysql_v2" "test" {
  region = "us-mia"
  label = "tf-test"
  type = "g6-nanode-1"
  engine_id = "mysql/8"

  allow_list = ["10.0.0.2/32", "10.0.0.3/32"]
  cluster_size = 3

  updates = {
    hour_of_day = 2
    day_of_week = 3
    frequency = "weekly"
    duration = 4
  }
}
  1. Ensure that the DB creation was successful and verify that the DB shows up in Cloud Manager.
  2. Look at the TF State and verify that the Port is not set to 0.
  3. Clean up any resources created.

@ezilber-akamai ezilber-akamai added the bugfix for any bug fixes in the changelog. label Jan 30, 2025
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner January 30, 2025 21:29
@ezilber-akamai ezilber-akamai requested review from lgarber-akamai and ykim-akamai and removed request for a team January 30, 2025 21:29
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the quick fix on this!

Just double checking, do we have a TF follow-up ticket for the other changes made in TPT-3243?

@ezilber-akamai
Copy link
Contributor Author

Looks great, thanks for the quick fix on this!

Just double checking, do we have a TF follow-up ticket for the other changes made in TPT-3243?

I don't believe so. In fact, I don't think we have TF follow-up tickets for any of the changes made in that epic (TPT-3247)

@ezilber-akamai ezilber-akamai merged commit c9cf63a into linode:dev Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants