Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wiki publishing gha #566

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

jriddle-linode
Copy link
Collaborator

📝 Description

What does this PR do and why is this change necessary?

Fixes the formatting of the workflow file, tested with ACT but unfortunately secrets dont work so well in ACT, I'm getting the same response I get from remote-release-trigger though so it seems to be progressing past my error now.

✔️ How to Test

How do I run the relevant unit/integration tests?

act -j publish-wiki

@jriddle-linode jriddle-linode requested a review from a team as a code owner January 3, 2024 21:04
@jriddle-linode jriddle-linode requested review from lgarber-akamai and zliang-akamai and removed request for a team January 3, 2024 21:04
@jriddle-linode jriddle-linode added the bug issues that report a bug label Jan 3, 2024
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some optional comments!

@lgarber-akamai
Copy link
Contributor

I've been getting the following error on the upload step on my fork:

fatal: could not read Password for 'https://***@github.com': No such device or address

Maybe I'm missing some permissions?

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my fork, great work!

@jriddle-linode jriddle-linode merged commit 59d4fb0 into linode:dev Jan 10, 2024
6 checks passed
@jriddle-linode jriddle-linode deleted the fix/wiki-publish branch January 10, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues that report a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants