new: retry on common errors #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In Python SDK we used the retry class from urllib3. Should we consider that for linode-cli as well or? https://github.com/linode/linode_api4-python/blob/dev/linode_api4/linode_client.py#L26 |
@zliang-akamai That's a great question! The biggest limitation I can think of with that approach is that it might be a good bit more complicated to implement complex retry logic (e.g. 400 NGINX errors).
|
lgarber-akamai
approved these changes
Aug 14, 2023
Co-authored-by: Lena Garber <[email protected]>
Co-authored-by: Ania Misiorek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
Adding retry functionality for common random errors sent by the API
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
make test