-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: retry on common errors #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
In Python SDK we used the retry class from urllib3. Should we consider that for linode-cli as well or? https://github.com/linode/linode_api4-python/blob/dev/linode_api4/linode_client.py#L26 |
@zliang-akamai That's a great question! The biggest limitation I can think of with that approach is that it might be a good bit more complicated to implement complex retry logic (e.g. 400 NGINX errors).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just needs a make format
run .
Co-authored-by: Lena Garber <[email protected]>
Co-authored-by: Ania Misiorek <[email protected]>
📝 Description
What does this PR do and why is this change necessary?
Adding retry functionality for common random errors sent by the API
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
make test