feat: new file structures that is more compatible with gitops approach #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-zimnowoda
changed the title
j-zimnowoda
commented
Feb 10, 2025
| const valuesPublic = omit(oldValues, secretPaths) | ||
| const valuesSecrets = pick(oldValues, secretPaths) | ||
|
|
||
| // FIXME migrate workloadValues folder and change ApplicationSet !! |
There was a problem hiding this comment.
@CasLubbers could you add migration for workloadValues?
Each team should have its own workloadValues directory.
It is good to remember that workload values do not need to be processed by core while deploying.
j-zimnowoda
commented
Feb 10, 2025
|
|
||
| export interface FileMap { | ||
| envDir: string | ||
| kind: |
There was a problem hiding this comment.
@merll Here are the proposed names for kinds
There was a problem hiding this comment.
From my understanding these are plural as we currently use them. But since Kubernetes CRDs usually are defined separately with singular and plural forms, maybe it would be better to indicate explicitly that there is no real singular form of these tuples of things. For example, it could be AplAlertSet, AplBackupSet etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.