Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CNPG recovery options #1926

Merged
merged 19 commits into from
Mar 19, 2025
Merged

feat: CNPG recovery options #1926

merged 19 commits into from
Mar 19, 2025

Conversation

merll
Copy link
Contributor

@merll merll commented Feb 4, 2025

This PR introduces new values not part of the platform API, but needed for recovering platform databases:

  • The recovery and externalClusters sections in the clusterSpec.bootstrap can be provisioned. Necessary since there are no rawValues for platform databases.
  • The location of new backups can be changed, so that the same bucket and credentials can be reused, adding different paths to the CNPG backup location (pathSuffix).
  • The linode-creds secret must be present before configuring a backup or recovery. For Harbor, this is configured sooner during the initial installation.
  • An issue with the retention of Gitea backups was discovered and fixed.
  • More defaults are added, fixing templating issues if e.g. schedule is not set in input values.
  • Rclone was updated to the latest release v1.69.0. If the checksum cannot be verified, there is an attempt to reinstall Rclone instead of failing.
  • Some older values used when migrating from the chart databases were removed.

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@merll merll changed the title CNPG recovery options feat: CNPG recovery options Feb 4, 2025
Copy link

github-actions bot commented Feb 5, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
47.77% (+0.1% 🔼)
975/2041
🔴 Branches
31.21% (+0.5% 🔼)
186/596
🔴 Functions
37.19% (+0.35% 🔼)
106/285
🔴 Lines
46.96% (+0.11% 🔼)
858/1827

Test suite run success

80 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 2e9a5ef

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, please add test fixtures for one of the db that covers rendering of the recovery and externalClusters properties

@merll merll merged commit 98d8bfe into main Mar 19, 2025
8 checks passed
@merll merll deleted the APL-220-cnpg-recovery branch March 19, 2025 13:39
Ani1357 pushed a commit that referenced this pull request Mar 19, 2025
Co-authored-by: Ani Argjiri <[email protected]>
Co-authored-by: jeho <[email protected]>
(cherry picked from commit 98d8bfe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants