-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CNPG recovery options #1926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success80 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 2e9a5ef |
Ani1357
approved these changes
Mar 7, 2025
j-zimnowoda
reviewed
Mar 7, 2025
j-zimnowoda
reviewed
Mar 7, 2025
j-zimnowoda
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, please add test fixtures for one of the db that covers rendering of the recovery
and externalClusters
properties
Ani1357
pushed a commit
that referenced
this pull request
Mar 19, 2025
Co-authored-by: Ani Argjiri <[email protected]> Co-authored-by: jeho <[email protected]> (cherry picked from commit 98d8bfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new values not part of the platform API, but needed for recovering platform databases:
recovery
andexternalClusters
sections in theclusterSpec.bootstrap
can be provisioned. Necessary since there are no rawValues for platform databases.pathSuffix
).linode-creds
secret must be present before configuring a backup or recovery. For Harbor, this is configured sooner during the initial installation.Checklist
adr/*.md
and appended to list inadr/_index.md
, if applicable.values-schema.yaml
file andtest/**
fixtures have been updated to reflect code changes, if applicable.values-schema.yaml
file, if applicable.