-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linked Open Vocabularies recommended ontology metadata #210
base: main
Are you sure you want to change the base?
Add Linked Open Vocabularies recommended ontology metadata #210
Conversation
@@ -497,14 +498,6 @@ slots: | |||
in_subset: | |||
- BasicSubset | |||
|
|||
publisher: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably deprecate this slot rather than delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't deleted, you can find it at line 2632 😇
I didn't delete any existing attribute, I only modified them to add some information.
- https://creativecommons.org/ns | ||
- https://lov.linkeddata.es/Recommendations_Vocabulary_Design.pdf | ||
|
||
creator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should creator
and contributor
be multivalued?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -49,6 +49,7 @@ prefixes: | |||
qudt: http://qudt.org/schema/qudt/ | |||
cdisc: http://rdf.cdisc.org/mms# | |||
SIO: http://semanticscience.org/resource/SIO_ | |||
cc: http://creativecommons.org/ns# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's stick to established prefixes, e.g bioregistry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't understand which part of this prefix is troublesome 😌
Is it the use of cc
which is too short ?
Or is it that Creative Commons cannot be considered as an established prefix ?
- https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#http://purl.org/dc/terms/creator | ||
- https://lov.linkeddata.es/Recommendations_Vocabulary_Design.pdf | ||
|
||
contributor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have contributors
, which can be applied at any level (schema, element, ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to be compliant with the Linked Open Vocabularies standards but I imagine I can just change the behavior in the OWL generator to convert contributors
to contributor
?
Then I'll have to find a way to manage multiple entries 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest breaking this up into smaller PRs, and doing a careful alignment with what already exists - e.g. we already have contributors
, so no need for contributor
596755f
to
1fb956b
Compare
Signed-off-by: Vincent Kelleher <[email protected]>
1fb956b
to
434ec7d
Compare
What should be the granularity of those PRs ? One per attribute ? |
What makes ontologies awesome is their reusability. To be reused an ontology needs to be discoverable and easily understandable through documentation (FAIR principles mention those requirements).
At Gaia-X we are working on making our LinkML generated ontology more discoverable and better documented through ontology metadata. The Linked Open Vocabularies project gives recommendations about how an ontology can be described through metadata by using well established vocabularies such as Dublin Core Terms, Creative Commons and OWL.
This pull request proposes a solution to integrate slots for this metadata in the schema definition to then use those slots in the LinkML generators.