Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(http/prom): Add metadata to Cargo.toml manifest #3230

Merged
merged 1 commit into from
Sep 25, 2024
Merged

docs(http/prom): Add metadata to Cargo.toml manifest #3230

merged 1 commit into from
Sep 25, 2024

Conversation

cratelyn
Copy link
Collaborator

this commit introduces a description and adds the authors.

@cratelyn
docs(http/prom): Add metadata to Cargo.toml manifest
e0a5060 
this commit introduces a description and adds the authors.

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn self-assigned this Sep 24, 2024
@cratelyn cratelyn marked this pull request as ready for review September 24, 2024 22:15
@cratelyn cratelyn requested a review from a team as a code owner September 24, 2024 22:15
olix0r
olix0r approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw we tend to omit authors now that it's no longer required. The authors keys tend to be a remnant of yesteryear.

@cratelyn
Copy link
Collaborator Author

Ah! That's helpful to know. I'll merge this for the sake of the description field, but appreciate the lore regarding the authors field. 🙂

@cratelyn cratelyn merged commit 4624122 into main Sep 25, 2024
15 checks passed
@cratelyn cratelyn deleted the kate/add-prom-manifest-metadata branch September 25, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r olix0r approved these changes

Assignees

@cratelyn cratelyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cratelyn @olix0r