Skip to content

Commit

Permalink
chore(app): Disallow warnings in policy router's backend metrics (#3227)
Browse files Browse the repository at this point in the history
a stray `#![allow(warnings)]` directive seems to have slipped in from
an initial prototyping phase.

this commit removes this directive from
`/linkerd/app/outbound/src/http/logical/policy/route/backend/metrics.rs`,
and addresses the newly unearthed warnings, related to unused imports.

Signed-off-by: katelyn martin <[email protected]>
  • Loading branch information
cratelyn authored Sep 24, 2024
1 parent d05b616 commit ca61220
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
#![allow(warnings)]

use crate::{BackendRef, ParentRef, RouteRef};
use futures::Stream;
use linkerd_app_core::{
metrics::prom::{self, encoding::*, EncodeLabelSetMut},
svc,
};
use linkerd_app_core::{metrics::prom, svc};
use linkerd_http_prom::{
record_response::{self, NewResponseDuration, StreamLabel},
NewCountRequests, RequestCount, RequestCountFamilies,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ use super::{
LabelGrpcRouteBackendRsp, LabelHttpRouteBackendRsp, RouteBackendMetrics,
};
use crate::http::{concrete, logical::Concrete};
use linkerd2_proxy_api::outbound::backend;
use linkerd_app_core::{
metrics::prom::Counter,
svc::{self, http::BoxBody, Layer, NewService, Service, ServiceExt},
svc::{self, http::BoxBody, Layer, NewService},
transport::{Remote, ServerAddr},
};
use linkerd_proxy_client_policy as policy;
Expand Down

0 comments on commit ca61220

Please sign in to comment.