Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] add rt topic name in store config #1293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arjun4084346
Copy link
Contributor

Summary, imperative, start upper case, don't end with a period

In future, we want to provide users/admin ability to create a new real time topic, probably with some different configurations, e.g. partition count. This new real time topic would co-exist with the old real time topic, so we want to give a new name to it.
This PR will make all the components check the real time topic's name, if it exists, in Store config. If Store config does not have any name, it would be assumed, that there is no new topic right now and we can use the old methodology "<store_name>_rt" to determine the real time topic name.

Resolves #XXX

How was this PR tested?

added integration tests.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@arjun4084346 arjun4084346 force-pushed the rttopicname branch 2 times, most recently from 1bbf6e7 to 6cedc00 Compare November 13, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant