Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a separate indis warmup executor service #961

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

bohhyang
Copy link
Contributor

Summary

As reported, some apps ramped to Indis timed out at warmup causing d2 client startup timeout, the warmup executor was a single-thread executor shared by ZK and Indis flow, leading to Indis warmup blocks ZK warmup.

While the RC fix will be reducing the rate limiting on Indis Observer, here we add a separate executor for indis warmup to prevent blocking/affecting ZK flow in the future.

Test Done

build and test

@bohhyang bohhyang merged commit 76fb4b6 into master Dec 22, 2023
2 checks passed
@bohhyang bohhyang deleted the boyang/indisWarmup branch December 22, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants