Use Node instead of D2Node and D2URIMap instead of NodeMap for xDS flow #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial intent of using D2Node was to pre-deserialize the JSON, but because there is no way for the rest.li client to actually leverage this, it simply re-serializes the JSON then deserializes it again. This causes memory pressure along with validation errors as numerical typesa get mungled.
ZoabKapoor
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Overall looks good, 1 question before merging: will this work with the existing Observer implementation today? It seems like we are expecting type.googleapis.com/indis.NodeMap instead of "type.googleapis.com/indis.D2NodeMap" (and similar for the other types), but as far as I know the Observer only serves these types today:
envoy.config.cluster.v3.Cluster
envoy.config.core.v3.TypedExtensionConfig
envoy.config.endpoint.v3.ClusterLoadAssignment
envoy.config.listener.v3.Listener
envoy.config.route.v3.RouteConfiguration
envoy.config.route.v3.ScopedRouteConfiguration
envoy.config.route.v3.VirtualHost
envoy.extensions.transport_sockets.tls.v3.Secret
envoy.service.runtime.v3.Runtime
indis.D2Node
indis.D2NodeMap
indis.D2SymlinkNode
indis.Stat
ZoabKapoor
reviewed
Oct 31, 2023
nizarm
requested changes
Nov 1, 2023
d2/src/main/java/com/linkedin/d2/discovery/stores/zk/SymlinkAwareZooKeeper.java
Show resolved
Hide resolved
… JSON data Additionally introduce a D2URI type which has a proper schema instead of being a Struct. This will significantly decrease the resource size sent by the observer and significantly decrease the cost of deserialization on the client.
d2/src/main/java/com/linkedin/d2/balancer/properties/UriPropertiesJsonSerializer.java
Outdated
Show resolved
Hide resolved
shivamgupta1
reviewed
Nov 7, 2023
This is causing all sorts of validation issues due to integers being interpreted as floats and vice versa
bohhyang
requested changes
Nov 13, 2023
bohhyang
reviewed
Nov 13, 2023
CHANGELOG.md
Outdated
| @@ -14,6 +14,9 @@ and what APIs have changed, if applicable. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [29.47.0] - 2023-11-13 | |||
| - Use Node(Map) instead of D2node(Map) | |||
There was a problem hiding this comment.
nit: to be more specific so people know it's about indis change, how about "Use Node and D2UriMap for observer flow"?
There was a problem hiding this comment.
Oops, yeah let me update the PR title as well
bohhyang
approved these changes
Nov 13, 2023
PapaCharlie
changed the title
PapaCharlie
changed the title
bohhyang
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial intent of using D2Node was to pre-deserialize the JSON, but because there is no way for the rest.li client to actually leverage this, it simply re-serializes the JSON then deserializes it again. This causes memory pressure along with validation errors as numerical typesa get mungled.