Skip to content

Commit

Permalink
Do not apply Idea and Eclipse plugins. (#640)
Browse files Browse the repository at this point in the history
PegasusPlugin should not force its users to apply either the Idea or
the Eclipse plugins. In some setups, neither plugin is needed, such
as when using IntelliJ's native Gradle import.
  • Loading branch information
tjni authored Jun 24, 2021
1 parent ec076d8 commit 96f4057
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ and what APIs have changed, if applicable.

## [Unreleased]

## [29.19.4] - 2021-06-23
- Do not apply Idea and Eclipse plugins.

## [29.19.3] - 2021-06-18
- More changes for Gradle 7 compatibility.
- Add schemas as source set resources and rely on the Java plugin to copy them
Expand Down Expand Up @@ -4982,7 +4985,8 @@ patch operations can re-use these classes for generating patch messages.

## [0.14.1]

[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.19.3...master
[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.19.4...master
[29.19.4]: https://github.com/linkedin/rest.li/compare/v29.19.3...v29.19.4
[29.19.3]: https://github.com/linkedin/rest.li/compare/v29.19.2...v29.19.3
[29.19.2]: https://github.com/linkedin/rest.li/compare/v29.19.1...v29.19.2
[29.19.1]: https://github.com/linkedin/rest.li/compare/v29.18.15...v29.19.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,6 @@
* test source sets.
* </p>
*/

public class PegasusPlugin implements Plugin<Project>
{
public static boolean debug = false;
Expand Down Expand Up @@ -648,8 +647,6 @@ public void apply(Project project)
checkGradleVersion(project);

project.getPlugins().apply(JavaPlugin.class);
project.getPlugins().apply(IdeaPlugin.class);
project.getPlugins().apply(EclipsePlugin.class);

// this HashMap will have a PegasusOptions per sourceSet
project.getExtensions().getExtraProperties().set("pegasus", new HashMap<String, PegasusOptions>());
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version=29.19.3
version=29.19.4
group=com.linkedin.pegasus
org.gradle.configureondemand=true
org.gradle.parallel=true
Expand Down

0 comments on commit 96f4057

Please sign in to comment.