Fix ByteBuffer errors to be compatible with Java 8 runtimes (#937)

* Fix `ByteBuffer` errors to be compatible with Java 8 runtimes * Increment version to 29.46.3 --------- Co-authored-by: Yan Zhou <[email protected]>
linkedin · Sep 27, 2023 · 1da9f81 · 1da9f81
1 parent 4e8dd72
commit 1da9f81
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,9 @@ and what APIs have changed, if applicable.
 
 ## [Unreleased]
 
+## [29.46.3] - 2023-09-26
+- Fix ByteBuffer errors to be compatible with Java 8 runtimes.
+
 ## [29.46.2] - 2023-09-25
 - add service/cluster-not-found count to simple load balancer jmx. And add entry-out-of-sync count to dual read monitoring.
 
@@ -5536,7 +5539,8 @@ patch operations can re-use these classes for generating patch messages.
 
 ## [0.14.1]
 
-[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.46.2...master
+[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.46.3...master
+[29.46.3]: https://github.com/linkedin/rest.li/compare/v29.46.2...v29.46.3
 [29.46.2]: https://github.com/linkedin/rest.li/compare/v29.46.1...v29.46.2
 [29.46.1]: https://github.com/linkedin/rest.li/compare/v29.46.0...v29.46.1
 [29.46.0]: https://github.com/linkedin/rest.li/compare/v29.45.1...v29.46.0

diff --git a/gradle.properties b/gradle.properties
@@ -1,4 +1,4 @@
-version=29.46.2
+version=29.46.3
 group=com.linkedin.pegasus
 org.gradle.configureondemand=true
 org.gradle.parallel=true

diff --git a/li-jersey-uri/src/main/java/com/linkedin/jersey/api/uri/UriComponent.java b/li-jersey-uri/src/main/java/com/linkedin/jersey/api/uri/UriComponent.java
@@ -73,6 +73,7 @@
 import java.net.URI;
 import java.net.URLDecoder;
 import java.nio.ByteBuffer;
+import java.nio.Buffer;
 import java.nio.CharBuffer;
 import java.nio.charset.Charset;
 import java.util.ArrayList;
@@ -831,7 +832,9 @@ private static ByteBuffer decodePercentEncodedOctets(String s, int i, ByteBuffer
         if (bb == null)
             bb = ByteBuffer.allocate(1);
         else
-            bb.clear();
+            // Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.clear()Ljava/nio/ByteBuffer based on the suggestions from
+            // https://stackoverflow.com/questions/61267495/exception-in-thread-main-java-lang-nosuchmethoderror-java-nio-bytebuffer-flip
+            ((Buffer)bb).clear();
 
         while (true) {
             // Decode the hex digits
@@ -849,16 +852,19 @@ private static ByteBuffer decodePercentEncodedOctets(String s, int i, ByteBuffer
 
             // Check if the byte buffer needs to be increased in size
             if (bb.position() == bb.capacity()) {
-                bb.flip();
+                // Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer based on the suggestions from
+                // https://stackoverflow.com/questions/61267495/exception-in-thread-main-java-lang-nosuchmethoderror-java-nio-bytebuffer-flip
+                ((Buffer)bb).flip();
                 // Create a new byte buffer with the maximum number of possible
                 // octets, hence resize should only occur once
                 ByteBuffer bb_new = ByteBuffer.allocate(s.length() / 3);
                 bb_new.put(bb);
                 bb = bb_new;
             }
         }
-
-        bb.flip();
+        // Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer based on the suggestions from
+        // https://stackoverflow.com/questions/61267495/exception-in-thread-main-java-lang-nosuchmethoderror-java-nio-bytebuffer-flip
+        ((Buffer)bb).flip();
         return bb;
     }