Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataframe #451
base: master
Are you sure you want to change the base?
Dataframe #451
Changes from 6 commits
aec6486
0df72a0
4b373c6
ace606f
0ce3fd2
26c6210
05b3e01
ae98cc8
1875588
1f36c78
77a8dc4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep "dataset" as one word.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss parameter description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss parameter description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss parameter description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just do a match on (
coordinateOptConfig
,lossFunctionFactory
)? ThisrETypeOpt
seems to be redundant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this becomes "None"? this is for fixed effect case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't what I was picturing when writing the design document - I was thinking of something more like
generateDataset
in the proof-of-concept tests:CoordinateDescent
callstrain
inFixedEffectCoordinate
with trainingDataFrame
train
callsgenerateDataset
generateDataset
drops unnecessary columns and trains aFixedEffectModel
CoordinateDescent
callsscore
inFixedEffectCoordinate
with trainingDataFrame
andFixedEffectModel
score
returns a newDataFrame
with a scores columnCoordinateDescent
callstrain
inRandomEffectCoordinate
with the scoredDataFrame
train
callsgenerateDataset
generateDataset
merges the offset column with the scores column, then drops unnecessary columns and trainsRandomEffectModel
CoordinateDescent
callsscore
inRandomEffectCoordinate
with the scoredDataFrame
andRandomEffectModel
score
returns a newDataFrame
with another scores columnThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you described is exactly what is implemented in the comments, but I put the corresponding code logic in different methods (instead of the one you suggested).
See CoordinateDescent line 192-208:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither
FixedEffectCoordinate
norRandomEffectCoordinate
should have references like this one to the raw training data - it should be passed in as input and the column drops can occur somewhere in the train/score functions IMO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the functions in FixedEffectDataset (same for RandomEffectDataset) into coordinate to reduce the code complexity.