Enable coefficient variance computation #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Test | ||
| def testUpdateObjective(): Unit = { | ||
| val problem = createProblem | ||
| val problem = createProblem() |
There was a problem hiding this comment.
I don't believe this function is side-effecting. If it's not, then the convention is to omit the parens.
There was a problem hiding this comment.
As per our talk offline: functions that have parameters must have the parentheses, even if all default arguments are used. Scala compiler enforces it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #128. It's smaller than it looks, there are a few style changes as well (now using the Spark style guide).
UPDATE: A test on the cluster confirms that variance information is now being output.