-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federated Clients: implement commitSync() and committed() #129
Open
jonlee2
wants to merge
1
commit into
linkedin:master
Choose a base branch
from
jonlee2:federated-consumer-commitsync
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions
33
...e-kafka-clients/src/main/java/com/linkedin/kafka/clients/common/LocationLookupResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright 2019 LinkedIn Corp. Licensed under the BSD 2-Clause License (the "License"). See License in the project root for license information. | ||
*/ | ||
|
||
package com.linkedin.kafka.clients.common; | ||
|
||
import java.util.Collections; | ||
import java.util.Set; | ||
|
||
|
||
// This contains the result of the location lookup for a set of topics/partitions or a map of values keyed by | ||
// topic/partitition. | ||
public abstract class LocationLookupResult { | ||
public enum ValueType { | ||
PARTITIONS, TOPICS, PARTITION_KEYED_MAP | ||
} | ||
|
||
private Set<String> _nonexistentTopics; | ||
|
||
public LocationLookupResult() { | ||
_nonexistentTopics = Collections.emptySet(); | ||
} | ||
|
||
public LocationLookupResult(/*Map<ClusterDescriptor, T> valuesByCluster, */Set<String> nonexistentTopics) { | ||
_nonexistentTopics = nonexistentTopics; | ||
} | ||
|
||
public abstract ValueType getValueType(); | ||
|
||
public Set<String> getNonexistentTopics() { | ||
return _nonexistentTopics; | ||
} | ||
} |
37 changes: 37 additions & 0 deletions
37
...lients/src/main/java/com/linkedin/kafka/clients/common/PartitionKeyedMapLookupResult.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright 2019 LinkedIn Corp. Licensed under the BSD 2-Clause License (the "License"). See License in the project root for license information. | ||
*/ | ||
|
||
package com.linkedin.kafka.clients.common; | ||
|
||
import java.util.Collections; | ||
import java.util.Map; | ||
import java.util.Set; | ||
|
||
import org.apache.kafka.common.TopicPartition; | ||
|
||
|
||
// This contains the result of the location lookup for a map keyed by partition across multiple clusters in a cluster | ||
// group. | ||
public class PartitionKeyedMapLookupResult<T> extends LocationLookupResult { | ||
private Map<ClusterDescriptor, Map<TopicPartition, T>> _partitionKeyedMapsByCluster; | ||
|
||
public PartitionKeyedMapLookupResult() { | ||
this(Collections.emptyMap(), Collections.emptySet()); | ||
} | ||
|
||
public PartitionKeyedMapLookupResult(Map<ClusterDescriptor, Map<TopicPartition, T>> partitionKeyedMapsByCluster, | ||
Set<String> nonexistentTopics) { | ||
super(nonexistentTopics); | ||
_partitionKeyedMapsByCluster = partitionKeyedMapsByCluster; | ||
} | ||
|
||
@Override | ||
public LocationLookupResult.ValueType getValueType() { | ||
return LocationLookupResult.ValueType.PARTITION_KEYED_MAP; | ||
} | ||
|
||
public Map<ClusterDescriptor, Map<TopicPartition, T>> getPartitionKeyedMapsByCluster() { | ||
return _partitionKeyedMapsByCluster; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you just delete the commented out part ?