Update frwiktionary.py #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the addition of two newlines
|
Hi @0x010C @pamputt @Poslovitch, have any of you had a chance to look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! As reported here, the bot seems to sometimes add two newlines when adding a new pronunciation to frwikt, resulting in blanks in the wiki pages.
As I understand it, it happens when the Prononciation section contains other information than just the audio recordings, i.e. subsections such as "Anagrammes", "Paronymes" etc. See here where it happened: 1, 2, and here where it did not: 3, 4.
I suggest this quick fix, but we may need to look more into details for specific cases where it may be needed to add two newlines.
I don't have the proper setup to test the bot's stack. Could you take a look please?